feat: add solana gas fees endpoint #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: revert unwanted ignore fix: remove solana web3js fix: remove unwanted spaces fix: lint fix: moove dependence to solana coinstack
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
kaladinlight
reviewed
Oct 2, 2024
|
Overall looks sounds, just updates to vernacular and suggestion to use We can update in the future to add |
kaladinlight
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1042
Description
Simply add the gas fee endpoint supporting the parameters
messageas
getFeeForMessagesupports aMessageparam, it feels simpler to support the base64 of the message so we don't even have to build the full tx to estimate fees but only compose instructions and send them through this endpointWe could also send the full base64 tx and decode the message part but why would we build the full TX to estimate gas fees while we can do it earlier? We can discuss about it if needed
We don't have a notion of slow, medium, fast gas fees, getFeeForMessage returns the best fees for the TX to be executed as fast as possible regarding the history of priority fees of the last TXs
Screenshots
Small test using a basic send TX:
