feat: keystore import #8442
Open
feat: keystore import #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Jan 3, 2025
|
|
||
| const hoverSx = { borderColor: 'blue.500' } | ||
|
|
||
| // TODO(gomes): use https://www.chakra-ui.com/docs/components/file-upload if/when we migrate to chakra@3 |
There was a problem hiding this comment.
Logic very much stolen from there
gomesalexandre
commented
Jan 3, 2025
Comment on lines
+148
to
+150
| if (!keystoreFile) { | ||
| throw new Error('No keystore uploaded') | ||
| } |
There was a problem hiding this comment.
a.k.a "this should never happen, but..."
gomesalexandre
commented
Jan 3, 2025
Comment on lines
+165
to
+168
| setError('mnemonic', { | ||
| type: 'manual', | ||
| message: 'walletProvider.shapeShift.import.invalidKeystore', | ||
| }) |
There was a problem hiding this comment.
Probably fine to ditch this one as we never end up there - but prefer to keep it in case we manage to detect the imported file as being a keystore or not, in which case we could move this catch and reach this error-handling
gomesalexandre
commented
Jan 3, 2025
| <VStack spacing={6}> | ||
| <FileUpload onFileSelect={handleFileSelect} /> | ||
|
|
||
| {keystoreFile && ( |
There was a problem hiding this comment.
Hide password field until selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box - web wire-up following shapeshift/hdwallet#703
Issue (if applicable)
Risk
Low - isolated to keystore imports
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/a8c50a0f-b6f3-44ca-b38d-415b71588991