Skip to content

feat: keystore import #8442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 8, 2025
Merged

feat: keystore import #8442

merged 17 commits into from
Jan 8, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 24, 2024

Description

Does what it says on the box - web wire-up following shapeshift/hdwallet#703

⚠️ Note for reviewers: do the usual verdaccio dance when reviewing this, as hdwallet PR is not merged/published yet. In other words this is already reviewable, but not yet mergeable.

TODO:

- [x] make it work
- [x] make it clean
- [x] make it pretty
- [x] error-handling
- [x] translations

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - isolated to keystore imports

Testing

  • Create a keystore from THORSwap
  • Confirm you're able to import a keystore as a ShapeShift wallet e2e
  • Error-handling re: wrong password is working

Engineering

  • ☝🏽

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ☝🏽

Screenshots (if applicable)

image image image image

https://jam.dev/c/a8c50a0f-b6f3-44ca-b38d-415b71588991

@gomesalexandre gomesalexandre changed the title wip: keystore import feat: keystore import Jan 3, 2025
@gomesalexandre gomesalexandre marked this pull request as ready for review January 3, 2025 12:41
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 3, 2025 12:41
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jam.dev/c/dfc5fed7-8a19-492a-adae-c81a7b8018e7

Perfect dude, only a few small not blocking comments, mostly discussion, looks fine enough to me so far

You're getting better and better at integrating things thought!

@gomesalexandre gomesalexandre enabled auto-merge (squash) January 8, 2025 20:59
@gomesalexandre gomesalexandre merged commit 35cafb1 into develop Jan 8, 2025
6 checks passed
@gomesalexandre gomesalexandre deleted the feat_keystore branch January 8, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystore wire up
2 participants