feat: don't initialize ethersProvider in module scope #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Feb 15, 2024
woodenfurniture
approved these changes
Feb 19, 2024
woodenfurniture
force-pushed
the
feat_ethers_provider_no_module_eval
branch
from
4565503 to
a85f27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shaves off one request off daemon.* calls, mostly here for posteriority - since the
resolvers/univ2is evaluated on splash screen, this means there is effectively a network request to the daemon while still in splash screen, which could be avoided.Stretching the idea some more, as we get more and more lazy with loading, we should ensure there are no requests being made to endpoints at module-scope level.
Pull Request Type
Issue (if applicable)
relates to #6193
Risk
Low to none
Testing
Engineering
getBlockNumberinitiator doesn't fire daemon.* requests at splash-screen level, but only after thatOperations
None
Screenshots (if applicable)