Support for CSC, VAR and ATR #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Kolkman <[email protected]>
caskolkm
force-pushed
the
support-csc-var-atr-v3.1.0
branch
from
7f4e55d to
3892063
Compare
caskolkm
commented
Nov 5, 2024
| <!-- --> | ||
| <!-- Power Unit Type --> | ||
| <!-- --> | ||
| <xs:simpleType name="PowerUnitType"> |
There was a problem hiding this comment.
Feel free to add more to this enum :)
KoviaX
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Thank you for your PR! Looks like a good improvement to the spec.
I have added some small comments that should be easy to fix. Could you also make a PR for the next upcoming backwards incompatible release (== main) where the new fields are mandatory instead of optional? That way we can make the messages more explicit, without breaking the current implementations in this 3.1 version.
| @@ -59,8 +64,7 @@ | |||
| <xs:complexType name="D-PrognosisISPType"> | |||
| <xs:attribute name="Power" type="xs:integer" use="required"> | |||
| <xs:annotation> | |||
| <xs:documentation>Power specified for this ISP in Watts. Also see the important notes about the sign of this attribute in the main documentation entry for the ISP element.</xs:documentation> | |||
| </xs:annotation> | |||
| <xs:documentation>Power specified for this ISP in the given PowerUnit. Also see the important notes about the sign of this attribute in the main documentation entry for the ISP element.</xs:documentation> </xs:annotation> | |||
There was a problem hiding this comment.
Since the new property is optional in this Pull Request, I would suggest adding something along the lines of: (If the field is missing, it should be interpreted as Watt) after PowerUnit.
| <xs:attribute name="Reference" type="xs:string" use="required"> | ||
| <xs:annotation> | ||
| <xs:documentation>Message reference, assigned by the DSO originating the FlexReservationUpdate.</xs:documentation> | ||
| </xs:annotation> | ||
| </xs:attribute> | ||
| <xs:attribute name="Unit" type="PowerUnitType" use="optional"> | ||
| <xs:annotation> | ||
| <xs:documentation>The unit of Power that applies to the Power of the ISP's.</xs:documentation> |
| <xs:attribute name="Power" type="xs:integer" use="required"> | ||
| <xs:annotation> | ||
| <xs:documentation>Remaining reserved power specified for this ISP in Watts.</xs:documentation> | ||
| <xs:documentation>Remaining reserved power specified for this ISP in the given PowerUnit.</xs:documentation> |
| @@ -189,6 +204,11 @@ | |||
| <xs:documentation>Service type for this request, the service type determines response characteristics such as latency or asset participation type.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="Unit" type="PowerUnitType" use="optional"> | |||
| <xs:annotation> | |||
| <xs:documentation>The unit of Power that applies to the Min/Max Power of the ISP's.</xs:documentation> | |||
| @@ -259,6 +278,11 @@ | |||
| <xs:documentation>Reference to the concerning contract, if applicable. The contract may be either bilateral or commoditized market contract.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="ServiceType" type="xs:string" use="optional"> | |||
| <xs:annotation> | |||
| <xs:documentation>Service type for this request, the service type determines response characteristics such as latency or asset participation type.</xs:documentation> | |||
There was a problem hiding this comment.
Service type for this request. The service type determines response characteristics such as latency and asset participation type.
| @@ -274,6 +298,11 @@ | |||
| <xs:documentation>ISO 4217 code indicating the currency that applies to the price of the FlexOffer.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="Unit" type="PowerUnitType" use="optional"> | |||
| <xs:annotation> | |||
| <xs:documentation>The unit of Power that applies to the Power of the ISP's within the OfferOptions.</xs:documentation> | |||
| @@ -387,6 +415,11 @@ | |||
| <xs:documentation>Reference to the concerning bilateral contract, if applicable.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="ServiceType" type="xs:string" use="optional"> | |||
| <xs:annotation> | |||
| <xs:documentation>Service type for this request, the service type determines response characteristics such as latency or asset participation type.</xs:documentation> | |||
There was a problem hiding this comment.
Service type for this request. The service type determines response characteristics such as latency and asset participation type.
| @@ -478,6 +516,11 @@ | |||
| <xs:documentation>ISO 4217 code indicating the currency that applies to all amounts (flex price, penalty and net settlement) in this message.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="Unit" type="PowerUnitType" use="optional"> | |||
| <xs:annotation> | |||
| <xs:documentation>The power unit that applies to all given powers in this message.</xs:documentation> | |||
There was a problem hiding this comment.
The power unit that applies to all given power values in this message.
| @@ -546,28 +589,27 @@ | |||
| </xs:attribute> | |||
| <xs:attribute name="BaselinePower" type="xs:integer" use="required"> | |||
| <xs:annotation> | |||
| <xs:documentation>Power originally forecast (as per the referenced baseline) for this ISP in Watts.</xs:documentation> | |||
| <xs:documentation>Power originally forecast (as per the referenced baseline) for this ISP in the given PowerUnit.</xs:documentation> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.