Fix deep model last layer bug #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhossein-razlighi
approved these changes
Jun 13, 2024
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss`
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
amirR01
pushed a commit
that referenced
this pull request
Oct 21, 2024
No need for Softmax at the end because of `nn.CrossEntropyLoss` (cherry picked from commit 0dd0fe0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the nn.CrossEntropyLoss is used as the criterion, regarding pytorch documentation, the loss fuction applies the softmax on the input. Therefore, there is no need to add an extra softmax layer at the end of the model.
https://github.com/sharif-ml-lab/IMDb-IR-System/blob/ab4e92b6957fe747331744d815946b4eb6b57d90/Logic/core/classification/deep.py#L28C1-L42C10?plain=1