-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 2561, send all [bat error]s to stderr in default_error_handler #2827
Open
deboard
wants to merge
16
commits into
sharkdp:master
Choose a base branch
from
deboard:issue#2561
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
54cec4a
issue 2561, send all [bat error]s to stderr in default_error_handler
deboard 6ea3ac7
issue 2561, send all [bat error]s to stderr in default_error_handler
deboard 6b90c21
Merge branch 'issue#2561' of github.com:deboard/bat into issue#2561
deboard 6a0f6be
Ammend CHANGELOG
deboard 76a655d
Merge branch 'issue#2561' of github.com:deboard/bat into issue#2561
deboard cb2f8f8
Ammend CHANGELOG... Again
deboard 7ae3185
Merge branch 'issue#2561' of github.com:deboard/bat into issue#2561
deboard 635175e
Ammend CHANGELOG... Again...
deboard 1f3e3e0
Ammend CHANGELOG... Again...
deboard e5858e2
Merge branch 'master' into issue#2561
deboard ed6aad7
Add test.
deboard 10fd0b7
Add integration test.
deboard b1819cb
Merge branch 'master' into issue#2561
deboard ac4f4b4
Ran cargo fmt.
deboard 2a29029
Merge branch 'issue#2561' of github.com:deboard/bat into issue#2561
deboard b05cde7
Merge branch 'master' into issue#2561
deboard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/bin/bash | ||
|
||
## test for issue 2561 | ||
|
||
OUTPUT=$(mktemp) | ||
BAT=bat | ||
code=$($BAT /tmp 2> $OUTPUT; cat $OUTPUT | grep error; echo $?) | ||
|
||
if [[ $code == 1 ]]; then | ||
echo "stderr test fsil" | ||
exit 1 | ||
fi | ||
|
||
exit 0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please turn this into a Rust-based integration test. See
tests/integration_tests.rs
and search for.stderr
to see some examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is still here. Can it be removed?