Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename submodule paths to fix Dependabot submodule updates #3201

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

victor-gp
Copy link
Contributor

@victor-gp victor-gp commented Feb 3, 2025

Fixes #3198.

Before:

After renaming to Javascript_(Babel):

After merging to master:

To mitigate a bug in the GitHub API that broke the Dependabot action
that updates submodules. See sharkdp#3198.
@victor-gp
Copy link
Contributor Author

I've noticed that these submodules have a .sublime-syntax counterpart, a file owned by bat in the same syntaxes/02_Extras/ directory as the submodule. [^1]

I've also noticed that the repositories the submodules point to don't have any sublime-syntax file, they have .tmLanguage files and similar. So I gather that the owned file is generated somehow from the submodule's own?

In such case, should we also rename those files?

[1] All 4 changed submodules, e.g.:

@victor-gp victor-gp changed the title Replace spaces in git submodule paths Rename submodule paths to fix Dependabot submodule updates Feb 3, 2025
@keith-hall
Copy link
Collaborator

I've also noticed that the repositories the submodules point to don't have any sublime-syntax file, they have .tmLanguage files and similar. So I gather that the owned file is generated somehow from the submodule's own?

Yes, we have this documented here: https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting

In such case, should we also rename those files?

I would say no, because unless the file contains a name key inside it's yaml contents, the base file name is the name given to the syntax definition and used when mapping syntaxes, setting language from the command line arg etc. So we don't want to change that 🙂

Copy link
Collaborator

@keith-hall keith-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@keith-hall keith-hall merged commit ac40f7c into sharkdp:master Feb 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot submodule updates are broken
2 participants