expose HYPERFINE_ITERATION to intermediate commands #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcl-ark
force-pushed
the
expose-run-var
branch
2 times, most recently
from
bd3ce78 to
e0f1fdb
Compare
Fixes: sharkdp#781 Expose the `$HYPERFINE_ITERATION` variable to intermediate commands. This will allow iteration-specific prepare/conclude, such as: ```bash hyperfine --runs 5 --prepare 'echo touch file${HYPERFINE_ITERATION}.dat' \ 'echo testing file${HYPERFINE_ITERATION}.dat' \ --conclude 'echo rm file${HYPERFINE_ITERATION}.dat' --show-output ```
willcl-ark
force-pushed
the
expose-run-var
branch
from
e0f1fdb to
f3191ef
Compare
|
I don't have a Windows machine (or much experience on that platform) to tidy up the added integration test, so have resorted to stripping the lines. If there is a cleaner way to |
willcl-ark
added a commit
to bitcoin-dev-tools/benchkit
that referenced
this pull request
Mar 13, 2025
Introduce a mandatory `--output-dir` option when running benchmarks. This will, in the future, be used to store benchmark configuration, results and run artifacts. Currently it will store configuration and the final run artifact, as the changes needed in hyperfine to expose the run iteration are not available yet. (see: sharkdp/hyperfine#807 )
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #781
Expose the
$HYPERFINE_ITERATIONvariable to intermediate commands. This will allow iteration-specific prepare/conclude, such as: