if=>when to unread number token symbols #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing crashes in sbcl when spamming the stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing "if" with "when" during "read-json-number-token"
This was causing issues in SBCL when spamming the stream - seemingly since the unread-char would break the stream sequence.
The issue still persists, but it was possible to spam the stream a lot more before breaking (in my case it's a unix socket connected stream).
This is honestly rather dumb, and feels like SBCL is doing something weird in case of "if" (since "when" should technically still macroexpand to if), but since based on CL spec - this should be of no difference, i'm just going to leave this here.