Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement surrogate pairs in the encoder. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpgoldman
Copy link
Collaborator

Original PR comment:

Transform surrogate pairs characters into appropriate JSON escape sequence.

Reference:
http://unicodebook.readthedocs.io/unicode_encodings.html#utf-16-surrogate-pairs

@rpgoldman rpgoldman changed the title Inplement surrogate pairs in the encoder. Implement surrogate pairs in the encoder. Nov 29, 2021
@ghard
Copy link

ghard commented Feb 3, 2022

Would the hold-up for one of these not being merged be that there are no test cases written?

@ghard
Copy link

ghard commented Feb 3, 2022

Also if encoding using surrogate pairs is likely to cause backwards-compatibility issues with people using this library, we could add a special variable to turn it on, and maybe an accompanying macro like with-non-bmp-char-surrogate-pairs?

@rpgoldman
Copy link
Collaborator Author

A test would really help, yes, and I think you are right to think it should have a switch to enable or disable this. I will have to have a quick look at the docs and then I will try to suggest a method for switching that has the same flavor as the other configuration mechanisms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants