fix: db port grab issue

shashwatahalder01 · Apr 1, 2024 · 03a049c · 03a049c
1 parent 4e6b941
commit 03a049c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.github/workflows/e2e_api_tests.yml b/.github/workflows/e2e_api_tests.yml
@@ -115,7 +115,7 @@ jobs:
               if: success()
               run: |
                   cd tests/pw
-                  echo "DB_PORT=$(docker ps -f ancestor='mariadb' -f name='tests-mysql' --format='{{.Ports}}' | sed -E 's/.*:(.*)->.*/\1/')" >> $GITHUB_ENV
+                  echo "DB_PORT=$(docker ps -f ancestor='mariadb:lts' -f name='tests-mysql' --format='{{.Ports}}' | sed -E 's/.*:(.*)->.*/\1/')" >> $GITHUB_ENV
 
             # db port
             - name: DB PORT
@@ -161,14 +161,14 @@ jobs:
             # Install browser binaries & OS dependencies if cache missed
             - name: Install Playwright browser binaries & OS dependencies
               id: pw-install
-              if: success() && steps.playwright-cache.outputs.cache-hit != 'true'
+              if: ${{ success() && steps.playwright-cache.outputs.cache-hit != 'true' }}
               run: |
                   cd tests/pw
                   npm run pw:browser-with-deps
 
             # # Install only the OS dependencies if cache hit  not needed
             # - name: Install Playwright OS dependencies
-            #   if: steps.playwright-cache.outputs.cache-hit == 'true'
+            #   if: ${{ steps.playwright-cache.outputs.cache-hit == 'true' }}
             #   run: |
             #     cd tests/pw
             #     npm run pw:deps-only
@@ -193,7 +193,7 @@ jobs:
             # Run API tests
             - name: 🧪 Running the api tests
               id: api-test
-              if: ${{ steps.db-port.outcome == 'success' }} || ${{ (steps.db-port.outcome == 'success' && (github.event_name == 'workflow_dispatch' && (github.event.inputs.testsuite == 'API' || github.event.inputs.testsuite == 'All')))  }}
+              if: ${{ always() && steps.db-port.outcome == 'success' }} || ${{ ( always() && steps.db-port.outcome == 'success' && (github.event_name == 'workflow_dispatch' && (github.event.inputs.testsuite == 'API' || github.event.inputs.testsuite == 'All')))  }}
               timeout-minutes: 5
               run: |
                   cd tests/pw