Skip to content

Project refactor #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: pw
Choose a base branch
from
Open

Project refactor #107

wants to merge 36 commits into from

Conversation

shashwatahalder01
Copy link
Owner

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

  • Closes #

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@shashwatahalder01 shashwatahalder01 added the enhancement New feature or request label Feb 13, 2025
@shashwatahalder01 shashwatahalder01 self-assigned this Feb 13, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Tests Summary

Commit SHA: 92cbf67

Test 🧪Total 📊Passed ✅Failed 🚨Flaky 🚧Skipped ⏭️Duration ⏰Coverage 🏁
API Tests40338800152m 47s79.88%
E2E Tests11239985131099m 13s83.22%

Aunshon and others added 18 commits February 13, 2025 12:13
@Aunshon
Replace DOKAN_PRO_SINCE with corresponding versions. (getdokan#2566)
234eb6a
@Aunshon
Replace DOKAN_LITE_SINCE with corresponding versions (getdokan#2567)
1658a61 
* Replace `DOKAN_PRO_SINCE` with corresponding versions.

* Replace `DOKAN_LITE_SINCE` with corresponding versions.
@shohag121
chore: DOKAN_PRO_SINCE support added (getdokan#2552)
0bd36d8
@shohag121
refactor: str_replace warning fix for OrderController
3709f64
@devAsadNur
🪓 fix: Prevented store URL generation for staff managers on admin das…
eb7ce58 
…hboard (getdokan#2505)

* fix: Prevent store URL generation for staff managers on admin dashboard

* fix: PHPCS issue on UserProfile class under Admin directory

* Shop URL made readonly on staff profile edit page
@shohag121
update: [dokan-customer-migration] shortcode migrated from pro. (ge…
d9ab0bb 
…tdokan#2553)

* update: `[dokan-customer-migration]` shortcode migrated from pro.

* refactor: rename class to `CustomerMigration` from `BecomeAVendor`
@kzamanbd
Restoring parent order with restore related child orders (getdokan#2557)
86e5788 
* fix: order restore from trash

Restoring the parent order with related child order

* resolve the pr feedback

* added type hint on args

* fix: child order args
@MdAsifHossainNadim
fix: Store settings api stores inconsistent data for switcher fields. (…
ef6ee48 
…getdokan#2571)

* fix: Store settings api stores inconsistent data for switcher fields.

* fix: phpcs issues.

* fix: store updating error for payment and admission_commision_type params.

* fix: store updating error for payment and admission_commision_type params.
@shohag121
update: Extendability support on dokan post count and stock count add…
1025a8d 
…ed. (getdokan#2560)
@Aunshon
chore: Release version 3.14.10
885bf86
@Aunshon
Merge branch 'develop' into release/3.14.10
7ba660a
@Aunshon
chore: Release version 3.14.10
2e4432f
@shohag121
Merge branch 'release/3.14.10' into develop
1d3ffc4
@shashwatahalder01
test(refactor): update tests for store api changes (getdokan#2582)
0f875de
@MdAsifHossainNadim
fix: DokanBaseController triggers error for rest_base missing on `f…
2560103 
…ormat_collection_response`.
@mrabbani
Update api.md
cb3b695
@mrabbani
Update DokanBaseController.php
9bc15c4
@MdAsifHossainNadim
Merge branch 'develop' into refactor/rest-api
332a0e4
mrabbani and others added 10 commits March 4, 2025 10:55
@mrabbani
Merge pull request getdokan#2544 from getdokan/refactor/rest-api
64e2a8d 
refactor: Dokan REST base controllers and docs
@mrabbani
Merge pull request getdokan#2579 from getdokan/refactor/fix-depricate…
c97b813 
…d-message

refactor: `str_replace` warning fix for `OrderController`
@osmansufy
Update/handle deprecated code from dokan (getdokan#2564)
f88e479 
* update: depricated class added

* update: replace dokan_doing_it_wrong with _doing_it_wrong

* update: @deprecated Dokan_Store_Location

* update: deprecated version

* update: alternative class/function suggest for deprecated function/class

* update:  Abstracts\DokanRESTController is replaced with REST\DokanBaseController
@mralaminahamed
fix: unsupported operand types: string in calculation (getdokan#2534)
ee29a18
@osmansufy
update: Sync Decimal Points with WooCommerce (getdokan#2569)
eea97c3 
* update: currency with default wc decimal

* update: remove 2 addition with wc_get_price_decimals

* update: remove 2 addition with wc_get_price_decimals in single product , order listing , product editor

* undo: placeholder in edit-product-single.php

* update: adjust decimal formatting in CommissionControllerV1.php

* update : undo eslint format product-editor.js
@MdAsifHossainNadim
fix: Elementor my account widget assets not loading in dokan register…
0b75162 
… form. (getdokan#2573)
@MdAsifHossainNadim
fix: Seller revoking access not proceed for Digital product. (getdoka…
630c56c 
…n#2574)
@Aunshon
Withdraw charge and receivable amount added in email template (getdok…
d1fad27 
…an#2575)
@osmansufy
fix: setup store country state validation (getdokan#2550)
8ab21fa 
* update: county state validation in store step

* fix: phpcs

* undo: space

* update: check null field state & country
@shashwatahalder01
Merge branch 'develop' into project_refactor
92cbf67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shashwatahalder01 shashwatahalder01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shashwatahalder01 @mrabbani @MdAsifHossainNadim @Aunshon @shohag121 @devAsadNur @kzamanbd @osmansufy @mralaminahamed