chrome only #99
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,7 +146,7 @@ export default defineConfig({ | |
| name: 'e2e_tests', | ||
| testMatch: /.*\.spec\.ts/, | ||
| /* whether not to run setup tests before running actual tests */ | ||
| // dependencies: NO_SETUP ? [] : ['e2e_setup'], | ||
|
There was a problem hiding this comment. 💡 Codebase verification Keep the e2e_setup dependency to maintain test reliability The e2e_setup dependency is part of a carefully designed test initialization chain:
🔗 Analysis chainVerify test dependencies before removing setup phase. Commenting out the e2e_setup dependency could lead to test failures if the environment is not properly initialized. Consider keeping the dependency and using the existing 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if any tests depend on environment setup
# Look for setup-dependent operations in test files
# Search for environment-dependent operations
rg -l "beforeAll|beforeEach" tests/e2e/
Length of output: 92 Script: #!/bin/bash
# First, find test files to understand the directory structure
fd -e ts -e js test
# Then look for setup patterns in the test files
rg -l "beforeAll|beforeEach|setup" tests/pw/
# Check the content of the config file for context
cat tests/pw/e2e.config.ts
Length of output: 12654 |
||
| /* whether not to run teardown tests after running actual tests */ | ||
| // teardown: NO_SETUP ? undefined : 'coverage_report', | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |||||
| "nid": "npm install --include=dev", | ||||||
| "nip": "npm install --omit=dev", | ||||||
| "pw:chrome-only": "playwright install chromium", | ||||||
| "pw:browser-with-deps": "playwright install --with-deps", | ||||||
|
There was a problem hiding this comment. Align browser installation with Chrome-only objective The current change installs all browsers, which contradicts the PR's "chrome only" objective and increases CI time unnecessarily. Apply this fix to install only Chrome: - "pw:browser-with-deps": "playwright install --with-deps",
+ "pw:browser-with-deps": "playwright install --with-deps chromium"📝 Committable suggestion
Suggested change
|
||||||
| "pw:deps-only": "playwright install-deps chromium", | ||||||
| "test": "npx playwright test", | ||||||
| "site:reset": "NO_SETUP=false npm run site:setup && npm run env:setup", | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,9 +3,14 @@ import { LoginPage } from '@pages/loginPage'; | |||||
| import { data } from '@utils/testData'; | ||||||
|
|
||||||
| test.describe('Admin functionality test', () => { | ||||||
| test.only('admin can login', { tag: ['@lite', '@admin'] }, async ({ page }) => { | ||||||
|
There was a problem hiding this comment. Remove .only to enable all tests. Using - test.only('admin can login', { tag: ['@lite', '@admin'] }, async ({ page }) => {
+ test('admin can login', { tag: ['@lite', '@admin'] }, async ({ page }) => {📝 Committable suggestion
Suggested change
|
||||||
| await page.goto('https://www.google.com/'); | ||||||
| await page.getByLabel('Search', { exact: true }).click(); | ||||||
| await page.getByLabel('Search', { exact: true }).fill('playwright.dev'); | ||||||
| await page.goto( | ||||||
| 'https://www.google.com/search?q=playwright.dev&sca_esv=445ea37e19471e67&hl=en&source=hp&ei=p-d8Z4euGMGJ4dUPwLHBuAM&iflsig=AL9hbdgAAAAAZ3z1t0_0F54ioUTUzvVc6jgP2g_yFzvM&ved=0ahUKEwjHnYiumuOKAxXBRLgEHcBYEDcQ4dUDCA4&uact=5&oq=playwright.dev&gs_lp=Egdnd3Mtd2l6Ig5wbGF5d3JpZ2h0LmRldjIFEAAYgAQyBRAAGIAEMgUQABiABDIFEAAYgAQyBRAAGIAEMgUQABiABDIFEAAYgAQyBRAAGIAEMgUQABiABEjbS1CeE1ioR3AGeACQAQCYAbMBoAH8D6oBBDMuMTS4AQPIAQD4AQGYAhegAsoQqAIKwgIKEAAYAxjqAhiPAcICChAuGAMY6gIYjwHCAggQABiABBixA8ICCxAAGIAEGLEDGIMBwgILEC4YgAQYsQMYgwHCAg4QABiABBixAxiDARiKBcICCxAuGIAEGNEDGMcBwgIHEAAYgAQYCsICBBAAGB7CAgYQABgKGB7CAgYQABgIGB7CAggQABgIGAoYHpgDBvEFu5uprVvqxY-SBwQ5LjE0oAeEZg&sclient=gws-wiz', | ||||||
| ); | ||||||
| await page.getByRole('link', { name: 'Playwright: Fast and reliable' }).click(); | ||||||
| }); | ||||||
|
|
||||||
| test('admin can logout', { tag: ['@lite', '@admin'] }, async ({ page }) => { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore build steps with Chrome-specific configuration.
Removing Node.js setup and build steps will break the workflow. These steps are essential even for Chrome-only testing.
Restore these steps with Chrome-specific configuration:
Also applies to: 87-94