feat(JavaScript): Allow changing action URL and more improvements #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silbinarywolf
commented
Jan 5, 2017
•
silbinarywolf
commented
- Change submit button(s) to change state on submit rather than on click (fixes bug where button disables for HTML5 validation)
- If field updating is a "select" tag type, replace it's "option" elements and trigger an update for Chosen/Select2. This is to avoid losing JS hooks on a form on the frontend.
- Add missing this._super() calls.
- Removed $this->owner->setForm(), the call makes no sense and caused a recursive loop when calling $this->owner->Link().
Add translatable and Lithuanian translation
* master: NEW Don't modify the field if no canCreate
Commits for 1.1.2
* master: fix(quickaddnew.css): Fix CSS so that the addnew button appears beside the chosen field in a way that works responsively. Fix enter key presses in input dialogs triggering the add new button. see: silverstripe/silverstripe-cms#1290 added croatian translation Added standard Scrutinizer config Adjusting codestyle a bit and adding phpdoc blocks Fixing phpdoc blocks to refering to Objects to built-in types of PHP Remove trailing spaces in the source code Fixing composer.json Converted to PSR-2 Added standard .editorconfig file Create LICENSE.md add support for Translatable or other instances when form action contains url parameters
…es bug where button disables for HTML5 validation), If field updating is a <select> type, replace it's <option> elements and trigger an update for Chosen/Select2 (avoid losing JS hooks on a form on the frontend), Add missing this._super() calls (fixes select2 not working when a quickaddnew button is added via AJAX)
|
Also just an FYI, this is for my MultiRecordField module: It needs to be able to rewrite the action URL so it can feed through the field. |
|
@sheadawson Any time to look over this? |
sheadawson
reviewed
Apr 6, 2017
| /** | ||
| * @var string | ||
| */ | ||
| protected $addNewAction; |
|
Soory @silbinarywolf looks like I started but didn't submit my feedback, see above |
|
Thanks for this work :) |
|
It wasn't used anywhere. I'm guessing I used it before I fixed the setForm() bug, then I proceeded to not use that property. Fixed now! |
|
Cool thought that might be the case, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.