Skip to content

fix: use MSRV aware resolver#189

Merged
ethanpailes merged 1 commit intomasterfrom
use-msrv-aware-resolver
Jan 22, 2025
Merged

fix: use MSRV aware resolver#189
ethanpailes merged 1 commit intomasterfrom
use-msrv-aware-resolver

Conversation

@ethanpailes
Copy link
Contributor

This configures cargo to use the MSRV aware resolver, which should hopefully prevent future release woes.

This configures cargo to use the MSRV aware resolver, which
should hopefully prevent future release woes.
@ethanpailes ethanpailes requested a review from Aetf January 22, 2025 18:11
@Aetf
Copy link
Contributor

Aetf commented Jan 22, 2025

Also need to update here: https://github.com/shell-pool/shpool/blob/master/.github/workflows/publish.yml#L32 to not use the pinned rust version

@ethanpailes
Copy link
Contributor Author

I think this will make us continue to work with the pinned toolchain, so we don't need to touch the publish pipeline at all. When I ran cargo package locally with this change applied, it worked.

@Aetf
Copy link
Contributor

Aetf commented Jan 22, 2025

Interesting. I thought the config value is only respected since 1.84 https://doc.rust-lang.org/cargo/reference/config.html#resolverincompatible-rust-versions

But if it works, then great :)

@ethanpailes
Copy link
Contributor Author

Yeah, I find it confusing. Maybe it won't work the next time we cut a release, in which case we can revisit.

@ethanpailes ethanpailes merged commit b99a1af into master Jan 22, 2025
5 checks passed
@ethanpailes ethanpailes deleted the use-msrv-aware-resolver branch January 22, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants