Merged
Conversation
This configures cargo to use the MSRV aware resolver, which should hopefully prevent future release woes.
Contributor
|
Also need to update here: https://github.com/shell-pool/shpool/blob/master/.github/workflows/publish.yml#L32 to not use the pinned rust version |
Contributor
Author
|
I think this will make us continue to work with the pinned toolchain, so we don't need to touch the publish pipeline at all. When I ran |
Contributor
|
Interesting. I thought the config value is only respected since 1.84 https://doc.rust-lang.org/cargo/reference/config.html#resolverincompatible-rust-versions But if it works, then great :) |
Aetf
approved these changes
Jan 22, 2025
Contributor
Author
|
Yeah, I find it confusing. Maybe it won't work the next time we cut a release, in which case we can revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configures cargo to use the MSRV aware resolver, which should hopefully prevent future release woes.