Merged
Conversation
Aetf
approved these changes
Feb 14, 2025
Contributor
Aetf
left a comment
Aetf
left a comment
There was a problem hiding this comment.
Looks good to me, just need to fix the formatting and rebase. Approve to unblock.
ethanpailes
force-pushed
the
upgrade-nix
branch
from
5ced31e to
67b7b58
Compare
This patch updates our nix dependency to 0.29. We didn't have to do anything for libshpool, but I had to make some tweaks to the test code. I was even able to delete an `unsafe` block, which is always nice.
ethanpailes
force-pushed
the
upgrade-nix
branch
from
67b7b58 to
b7e75a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates our nix dependency to 0.29.
We didn't have to do anything for libshpool, but
I had to make some tweaks to the test code. I
was even able to delete an
unsafeblock, whichis always nice.