-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
data.json : Added 15 sites / Removed 1 site #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
## Added sites : - Apple Music - ArchDaily - Canva - ComeUp - CommentCaMarche - Figma - Finary - Pexels - Skillshare + stats.fm + TripAdvisor + Volt.fm + Habbo + Shutterstock + SkyPixel Removed sites : Skyrock.com (Website closed)
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Given that some time has passed, it's possible that some of the failures are just due to drift If you could correct or opine on the above then we'd love to move forward with a merge |
+ Remove gfycat because it closed
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Sorry I couldn't determine why F- are happening. I've updated Gfycat that has disappeared and updated method on ArchDaily. |
False negatives are where the site fails to return results for usernames that are in fact valid. As an example, when testing with your PR manually, this is what I see returned:
The first result is expected to be blank due to it being a fake username, but the second result should return an account. This can be tested locally by using the Status code is by far the most reliable method, but sometimes it requires additional headers to be specified or request_method to be set to GET. Using an error message is of course acceptable, it just might sometimes be unreliable due to regional or lingual differences. If you need some help getting those items sorted out, I may be able to check them out myself --- it'd just have to wait for some availability is all. PS - |
👋
I've added a few websites to the list. I've also removed one that closed.
Added sites :
Removed sites :
Skyrock.com (Website closed)