Skip to content

Conversation

Lulucmy
Copy link

@Lulucmy Lulucmy commented Sep 22, 2024

👋
I've added a few websites to the list. I've also removed one that closed.

Added sites :

  • Apple Music
  • ArchDaily
  • Canva
  • ComeUp
  • CommentCaMarche
  • Figma
  • Finary
  • Pexels
  • Skillshare
  • stats.fm
  • TripAdvisor
  • Volt.fm
  • Habbo
  • Shutterstock
  • SkyPixel

Removed sites :

Skyrock.com (Website closed)

Lulucmy and others added 5 commits September 22, 2024 17:42
## Added sites :
- Apple Music
- ArchDaily
- Canva
- ComeUp
- CommentCaMarche
- Figma
- Finary
- Pexels
- Skillshare + stats.fm + TripAdvisor + Volt.fm + Habbo + Shutterstock + SkyPixel
Removed sites : 
Skyrock.com (Website closed)
Copy link
Contributor

Automatic validation of changes

Target F+ Check F- Check
ComeUp ✔️   Pass ❌   Fail
Apple Music ✔️   Pass ✔️   Pass
gfycat ❌   Fail ❌   Fail
Figma ✔️   Pass ❌   Fail
Fiverr ❌   Fail ✔️   Pass
ArchDaily ❌   Fail ✔️   Pass
Pexels ✔️   Pass ❌   Fail
Shutterstock ✔️   Pass ❌   Fail
SkyPixel ❌   Fail ✔️   Pass
Habbo ❌   Fail ✔️   Pass
Canva ✔️   Pass ❌   Fail
Skillshare ✔️   Pass ❌   Fail
stats.fm ✔️   Pass ✔️   Pass
TripAdvisor ✔️   Pass ❌   Fail
Volt.fm ✔️   Pass ✔️   Pass
Finary ✔️   Pass ✔️   Pass
Comment \xc7a Marche ✔️   Pass ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@ppfeister
Copy link
Member

Given that some time has passed, it's possible that some of the failures are just due to drift

If you could correct or opine on the above then we'd love to move forward with a merge

Copy link
Contributor

Automatic validation of changes

Target F+ Check F- Check
Figma ✔️   Pass ❌   Fail
Canva ✔️   Pass ❌   Fail
stats.fm ✔️   Pass ✔️   Pass
Habbo ❌   Fail ✔️   Pass
Comment \xc7a Marche ✔️   Pass ✔️   Pass
SkyPixel ❌   Fail ✔️   Pass
Apple Music ✔️   Pass ✔️   Pass
Fiverr ❌   Fail ✔️   Pass
Skillshare ✔️   Pass ❌   Fail
TripAdvisor ✔️   Pass ❌   Fail
ComeUp ✔️   Pass ❌   Fail
ArchDaily ✔️   Pass ✔️   Pass
Shutterstock ✔️   Pass ❌   Fail
Volt.fm ✔️   Pass ✔️   Pass
Finary ✔️   Pass ✔️   Pass
Pexels ✔️   Pass ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@Lulucmy
Copy link
Author

Lulucmy commented Sep 28, 2025

Sorry I couldn't determine why F- are happening. I've updated Gfycat that has disappeared and updated method on ArchDaily.
Should I switch the failed sites to message detection?

@ppfeister
Copy link
Member

False negatives are where the site fails to return results for usernames that are in fact valid.

As an example, when testing with your PR manually, this is what I see returned:

$ sherlock -j 2301 --print-all --site figma giureag figma
[*] Checking username giureag on:

[-] Figma: Not Found!

[*] Checking username figma on:

[-] Figma: Not Found!

[*] Search completed with 0 results

The first result is expected to be blank due to it being a fake username, but the second result should return an account.

This can be tested locally by using the --local flag, which will use your local data.json copy. You may need to enter the venv by $(poetry env activate) or use poetry run sherlock --local --site figma ... to skip venv activation.
[Install Poetry]

Status code is by far the most reliable method, but sometimes it requires additional headers to be specified or request_method to be set to GET. Using an error message is of course acceptable, it just might sometimes be unreliable due to regional or lingual differences.

If you need some help getting those items sorted out, I may be able to check them out myself --- it'd just have to wait for some availability is all.


PS - username_unclaimed was deprecated a while ago in favor of randomized checks, since it was easily defeated by people just registering those names. The schema requires these items to not be present (this is the only reason why the main integration tests failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants