rpc: pass "params" keyword dictionary to clightning #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client but also still accept a "params" array to be backward compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with shesek/lightning-client-js#4 this passes "params"
{key: val, ...}dictionary directly to c-lightning. So we can use keywords instead of exactly ordered (and obligatorynull) positional args.A "params"
[ val, val2,... ]array with positional args is still accepted, so I think clients can migrate slowly.Hope this doesn't break anything, a basic regtest with existing Spark-client v0.3.2-rc (on emulator) showed no issues.
Inspired while trying to fix the Spark/Sparko backend of Zeus wallet.
edit: Spark's custom rpc methods,
_listinvoices,_listpaysetc. still require positional args to be passes as array.