Skip to content

User/omolemo/notifications framework#2479

Open
OmolemoBlessingLethuloe wants to merge 6 commits intomainfrom
user/omolemo/notifications-framework
Open

User/omolemo/notifications framework#2479
OmolemoBlessingLethuloe wants to merge 6 commits intomainfrom
user/omolemo/notifications-framework

Conversation

@OmolemoBlessingLethuloe
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@IvanIlyichev IvanIlyichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OmolemoBlessingLethuloe. I've added first part of inline comments, please review them and resolve, then I'll be able to continue with review

Comment thread shesha-core/src/Shesha.Framework/Configuration/SheshaSettingNames.cs Outdated
Comment thread shesha-core/src/Shesha.Core/Domain/NotificationChannelConfig.cs Outdated
Comment thread shesha-core/src/Shesha.Core/Domain/NotificationGatewayConfig.cs Outdated
Comment thread shesha-core/src/Shesha.Core/Domain/NotificationTypeConfig.cs Outdated
Comment thread shesha-core/src/Shesha.Core/Domain/NotificationGatewayConfig.cs
Comment thread shesha-core/src/Shesha.Application/Notifications/NotificationAppService.cs Outdated
Comment thread shesha-core/src/Shesha.Application/Notifications/NotificationAppService.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants