Skip to content

Removal of C# from Duffman Coding #556

Merged
shhossain merged 6 commits intoshhossain:mainfrom
jhuynh06:jhuynh06-removalC#Duffman
Oct 29, 2022
Merged

Removal of C# from Duffman Coding #556
shhossain merged 6 commits intoshhossain:mainfrom
jhuynh06:jhuynh06-removalC#Duffman

Conversation

@jhuynh06
Copy link
Copy Markdown
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. Your PR title can be also used in here.

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc)
  • Modifications (modifying existing content, adding new content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This is simply a reminder of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added the necessary explanation
  • I have added the necessary links in the working section
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name in the contributors list

Comment "@all-contributors please add @your_username for content" to add your name in the contributors list.
You can change the "content" with any of this

Reviewers:

  • @username

If you adding code, please make sure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information to the code.

@the-label-bot the-label-bot Bot added kind/documentation kind/documentation size/L size/L labels Oct 29, 2022
@the-label-bot
Copy link
Copy Markdown

the-label-bot Bot commented Oct 29, 2022

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.902 ✔️
Size L 0.858 ✔️

@jhuynh06
Copy link
Copy Markdown
Contributor Author

The java class is functional, but it needs to be separated into two separate files, and "import java.util.PriorityQueue;" needs to be added to the second file.

@shhossain shhossain merged commit 1082939 into shhossain:main Oct 29, 2022
@shhossain
Copy link
Copy Markdown
Owner

The java class is functional, but it needs to be separated into two separate files, and "import java.util.PriorityQueue;" needs to be added to the second file.

Merging.

@shhossain shhossain linked an issue Oct 31, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation kind/documentation size/L size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove broken code in readme files. (python, cpp, c#, java, etc)

2 participants