Add static dispatch macros #318
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a bit of work, but I wanted to get some feedback before proceeding further. I haven't even tried building it for anything other than x86, and I haven't tried using the macros yet.
There are a few features that I'm not sure what to test for because I'm not sure what SLEEF is really looking at. Specifically, the tests for FMA… I guess for x86 that means the FMA4 ISA extension, but what about for other architectures? Should I just be looking at
__FP_FAST_FMA__/__FP_FAST_FMAF__, or is there something else?Overall, does this seem like the right approach to you?