Fix make_mongo_filter #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #14 |
|
Great job finding this issue ! |
|
yeah +1 to you @GuusH :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll log an issue with all the details. Suffice it to say here: the arribute 'message' was missing in the 'good_attributes' and 'string_attributes' lists, which caused this module to get all logs from mongodb as it generated a wrong filter when using the reporting functionality in Thruk instead of the relevant logs.
It used to get several tens of thousands of log entries, on which this module choked later on. This doesn't solve the choking, but it does make sure that it only grabs the relevant logs and as long as that's a not insane amount, it can be processes just fine. My test reports which reliably always broke this module now work just fine.