Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: compare between kafka and rabbitmq and add its client and server in the project #3

Open
shivamsouravjha opened this issue Sep 28, 2024 · 5 comments
Assignees

Comments

@shivamsouravjha
Copy link
Owner

  • When a stock isn't found in mongodb or in searchcompany function it should generate a new event and send it to a queue.
  • The consumer of the messaging queue would be processing the name of stock to be sent via email to a certain email behind env variable.
@diwanatharv
Copy link
Contributor

Hello @shivamsouravjha ,
Regarding your request to compare Kafka and RabbitMQ and add their clients and servers to the project, I have a suggestion:
Would you consider using Amazon Simple Queue Service (SQS) instead of Kafka or RabbitMQ for this use case?

@shivamsouravjha
Copy link
Owner Author

@diwanatharv as of now most of my services are completely free, amazon based services would need an account having an on server client and server for rabbitmq is a compartively cheaper solution

@selamanse
Copy link

@shivamsouravjha I'd like to try this. can you assign me?

also some questions:

  • what kind of comparison would you like to have? or do you just need an interface for event dispatching (regardless of brokerdesign).
  • do you have an eventmodel in mind? which data should be part of the event?
  • "When a stock isn't found in mongodb or in searchcompany function" -> is there already code that explicitly handle these situations?

@shivamsouravjha
Copy link
Owner Author

Hey @selamanse !

  • by comparsion I meant a basic difference about which design criteria is used to pick kafka or rabbitmq.
  • this events should be either failure events or
{
  "eventType": "StockNotFound/MutualFundParsingFailed",
  "eventId": "12345-abcde",
  "timestamp": "2024-10-10T12:34:56Z",
  "data": {
    "urlOfMututalFund/stockname": "u123",
  },
  "correlationId": "7890-xyz"
}

  • in file_service.go we've if score, ok := result["score"].(float64); ok { where we check for any this, there are conditions to deal with this .

@selamanse
Copy link

@shivamsouravjha can you have a look if #34 is going into the right direction?

where do you want to have the consumer integration? will it be the same package / same process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants