Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kafka #34

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

selamanse
Copy link

This adds an kafka integration for events emitted as discussed in #3

It emits events of different types in the shape of StockbackendEvent.

There is no consumer implementation - please use vscode devcontainer for a fully fledged environment (using kafka for vscode integration)

@shivamsouravjha
Copy link
Owner

shivamsouravjha commented Oct 27, 2024

there are a few merge conflicts

@shivamsouravjha
Copy link
Owner

also any reason to pick kafka over rabbitmq?

@shivamsouravjha
Copy link
Owner

also I originally intended that incase of a stock not found in data or some mutual fund not being able to parse I would create an event and send to consumer which would then send the details over to my mail.

@selamanse
Copy link
Author

selamanse commented Oct 31, 2024

also any reason to pick kafka over rabbitmq?

not really...kafka is "hot" right now and a dev environment is set up pretty easily.
imho for dev environments it does not really matter which messaging system you use.
but read on for pattern details:

also I originally intended that incase of a stock not found in data or some mutual fund not being able to parse I would create an event and send to consumer which would then send the details over to my mail.

thanks for elaborating.

so in this scenario kafka might not be the best choice since its strengths are in event streaming (e.g. real-time logs).

since you want to have a point-to-point model implemented (e.g. error notifications via mail) rabbit mq might be the better choice, and also there is the infrastructural complexity aspect (in which rabbit mq would also be the preferable).

If you want to test for your self - I will implement a rabbitmq version in a different PR today for comparison.
You can also have both systems supported in your application - depending on your final setup this might be a good start to test both systems under production circumstances (also learn how they behave)

@selamanse
Copy link
Author

I have also added an rabbitmq implementation in #36.

P.S.: If you like the path we are going: I'd appreciate an "hacktoberfest-accepted" label on either or both of these PRs. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants