Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pythonic import #4992

Merged
merged 1 commit into from
Apr 3, 2020
Merged

use pythonic import #4992

merged 1 commit into from
Apr 3, 2020

Conversation

LiuYuHui
Copy link
Contributor

@LiuYuHui LiuYuHui commented Apr 3, 2020 •
edited by gf712
Loading

fixes part of #4990

@gf712
Copy link
Member

gf712 commented Apr 3, 2020

Cool! Looks good. What do you think @karlnapf?

@karlnapf karlnapf mentioned this pull request Apr 3, 2020
Closed
@karlnapf
Copy link
Member

karlnapf commented Apr 3, 2020

looks good. Note there is more code that does the old style import (see issue)

@gf712
Copy link
Member

gf712 commented Apr 3, 2020

Yup, I'll merge but remove "fix" so it doesn't close the issue

@gf712 gf712 merged commit 2cd7ce2 into shogun-toolbox:develop Apr 3, 2020
@LiuYuHui LiuYuHui deleted the pythonic_import branch April 3, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiuYuHui @gf712 @karlnapf