Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eigenfaces.py #5023

Closed
wants to merge 4 commits into from

Conversation

mohitmajithia
Copy link

made changes in this file #4990

made changes in this file shogun-toolbox#4990
np.float64).T)
dist = EuclideanDistance( test, projection).distance(0,0)
dist = sg.EuclideanDistance( test, projection).distance(0,0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, need to replace with factory

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which factory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and where can i read about sg factories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg.create_distance("EuclideanDistance")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where will test and projection go?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg.create_distance("EuclideanDistance", lhs=test , rhs=projection), you can find those from shogun example btw.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where to see shogun examples?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks btw

@gf712 gf712 mentioned this pull request May 4, 2020
@mohitmajithia
Copy link
Author

now how to edit code?

@gf712
Copy link
Member

gf712 commented May 4, 2020

have you tested this locally? Because the CI doesn't test these examples

@mohitmajithia
Copy link
Author

how to test locally?

@gf712
Copy link
Member

gf712 commented May 4, 2020

compile shogun and run this script with python...

@mohitmajithia
Copy link
Author

how to compile shogun
sorry i am new

@LiuYuHui
Copy link
Contributor

LiuYuHui commented May 4, 2020

how to test locally?

please read this, everything you want know is in that.
https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/DEVELOPING.md

@gf712
Copy link
Member

gf712 commented May 4, 2020

all the information needed is on our GitHub wiki

@mohitmajithia
Copy link
Author

ok thanks

@karlnapf
Copy link
Member

closing

@karlnapf karlnapf closed this May 11, 2020
@karlnapf
Copy link
Member

(feel free to re-open if you continue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants