-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eigenfaces.py #5023
Update eigenfaces.py #5023
Conversation
made changes in this file shogun-toolbox#4990
np.float64).T) | ||
dist = EuclideanDistance( test, projection).distance(0,0) | ||
dist = sg.EuclideanDistance( test, projection).distance(0,0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, need to replace with factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which factory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and where can i read about sg factories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg.create_distance("EuclideanDistance")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where will test and projection go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg.create_distance("EuclideanDistance", lhs=test , rhs=projection)
, you can find those from shogun example btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where to see shogun examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks btw
now how to edit code? |
have you tested this locally? Because the CI doesn't test these examples |
how to test locally? |
compile shogun and run this script with python... |
how to compile shogun |
please read this, everything you want know is in that. |
all the information needed is on our GitHub wiki |
ok thanks |
closing |
(feel free to re-open if you continue :) |
made changes in this file #4990