Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add arg to find-plans that limits number of plans returned (shop classic) #146

Open
mpatsift opened this issue Sep 7, 2023 · 2 comments

Comments

@mpatsift
Copy link
Contributor

mpatsift commented Sep 7, 2023

Add an arg to find-plans that limits the number of plans returned.

@mpatsift
Copy link
Contributor Author

mpatsift commented Sep 7, 2023

Two poss implementations:
(1) Add plan-num-limit arg (default value 1) which limits number of plans returned when :which is :first or :random.

(2) Same as (1), but plan-num-limit applies to :all and :random. (plan-num-limit defaults to nil.)

I have draft implementation of (1), but (2) may be more obvious to callers.

@rpgoldman
Copy link
Contributor

1 sounds fine to me -- will you please make a MR for this, and we will get it merged for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants