Issue 146: Feature: add arg to find-plans that limits number of plans returned (shop classic and ESS) #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2023 13:04
New plan-num-limit arg modifies number of plans returned by search when :which is set to :first or :random when set to non-default value (default is 1). NOTE: only applies to "classic" (not explicit stack) find-plans. * shop3/shop3.lisp - Add arg to find-plans. - Update doc string. * shop3/decls.lisp - Declare *plan-num-limit*. * shop3/planning-engine/search.lisp - Check *plan-num-limit* in when-done macro.
Add plan-num-limit-tests test suite.
Bump the minor version for addition of new feature.
Also update the copyright on shop3.lisp.
rpgoldman
approved these changes
Sep 13, 2023
|
Marked as draft until I fix the last test failure. |
Previously, because we were pushing onto the set of plans found, I didn't notice that we did not re-bind `*plans-found*` as required.
rpgoldman
changed the title
Lower bound for plan-num-limit is 1, not zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #146 and add tests.