Add some compiler macros and other tweaks to build clean #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several improvements for compilation, specifically on SBCL. Add `verify-type`, a macro that is like `check-type`, but that does not have a restart. The restart was confusing SBCL's type-checker. Fix an old SHOP2 package. In one other place I replaced `assert` with `unless` + `error`.
These compiler macros get rid of trivial cases in `apply-substitution` and `seek-satisfiers` macros that were causing distracting code removal messages on SBCL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some compiler macros that let us prune some unreachable branches in the theorem-prover, when argument values are known at compile time.
Other improvements for compilation, specifically on SBCL:
Add
verify-type, a macro that is likecheck-type, but that does not have a restart. The restart was confusing SBCL's type-checker by making it think that the type of some variables was unknown. Replaced by simply erroring out.Fix use of old "SHOP2" package name.
Replace
assertwithunless+error.