Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Loop fixes and other parametric setup for dependencies. #58

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

matthewdehaven
Copy link
Contributor

Also added debugging information and flags per plan tree dependencies.

Also added debugging information and flags per plan tree dependencies.
@matthewdehaven
Copy link
Contributor Author

@ukuter's branch. I think it is intended to merged back into master, but am unsure if it is ready. There are some debugging prints still in this branch, for instance.

Xach has added SHOP3 to the Quicklisp distribution, so it is now may be installed simply by using `quickload`.
Made a mistake in the Markdown
The (f)lex command was incorrect.  Syntactically it was wrong, the
pathname was wrong, *and* errors were masked by using `;` instead of
`&&`.
Fix to the Makefile for VAL.  Thanks to @ko56 for query #63, identifying the problem.
Several helpful updates from @ko56 and that triggered me groveling over a lot of Texinfo issues in the manual. Should be much better now.
mdehavensift and others added 12 commits May 9, 2021 14:41
@ko56 (Kostas Oikonomou) has kindly done substantial edits to the documentation, notably fixing up a lot of the typography, and also added a simple example for novices.
`shop-trace-info` wasn't exported.
Fix some stylistic issues in the trace code.
* Manual fixes from Kostas (@ko56)
* Minor edits by me (@rpgoldman)
* Fix some crossreferences not handled properly in the translation from Microsoft Word.
* Make citations into cross-references.
* Swap chapters per Kostas's suggestion: Put "General Notes on Shop3" ahead of "Internal Technical Information."
Check build more stringently and fix some problems with test evaluation.
Also added debugging information and flags per plan tree dependencies.
Also added the capability to interleave :FOR loops with a :COND in them. It's limited to only this kind of nesting right now and needs to be testing more before a merge.
@rpgoldman
Copy link
Contributor

@matthewdehaven How would you feel about rebasing this on master, and then I will try to do the review?

@rpgoldman
Copy link
Contributor

Please see #142 which resolves the conflicts.

Also, if it takes a while to get this merged, let's regularly rebase it on the current master, instead of letting it diverge too far.

@rpgoldman
Copy link
Contributor

Should we kill this MR, now that we have the rebased one: #142 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants