Skip to content

[16.0] [IMP] shopinvader_api_sale: Add sale_line router#1508

Merged
shopinvader-git-bot merged 1 commit intoshopinvader:16.0from
akretion:16.0-imp-shopinvader_api_sale-add-sale_line
Sep 1, 2025
Merged

[16.0] [IMP] shopinvader_api_sale: Add sale_line router#1508
shopinvader-git-bot merged 1 commit intoshopinvader:16.0from
akretion:16.0-imp-shopinvader_api_sale-add-sale_line

Conversation

@paradoxxxzero
Copy link
Copy Markdown
Contributor

@paradoxxxzero paradoxxxzero commented Mar 1, 2024

No description provided.

@paradoxxxzero paradoxxxzero force-pushed the 16.0-imp-shopinvader_api_sale-add-sale_line branch from 5e21d7d to e1c2907 Compare March 5, 2024 14:38
This was referenced Mar 7, 2024
Closed
Open
@sebastienbeau sebastienbeau added this to the 16.0 milestone Jun 3, 2024
@paradoxxxzero paradoxxxzero marked this pull request as ready for review June 4, 2024 13:51
@paradoxxxzero paradoxxxzero changed the title [WIP] [16.0] [IMP] shopinvader_api_sale: Add sale_line router [16.0] [IMP] shopinvader_api_sale: Add sale_line router Jun 4, 2024
sebastienbeau
sebastienbeau reviewed Jun 4, 2024
View reviewed changes
Comment thread shopinvader_api_sale/schemas.py Outdated
sebastienbeau
sebastienbeau requested changes Jun 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more info on lines

@paradoxxxzero paradoxxxzero force-pushed the 16.0-imp-shopinvader_api_sale-add-sale_line branch from e1c2907 to e21f162 Compare June 6, 2024 10:55
@paradoxxxzero
Copy link
Copy Markdown
Contributor Author

paradoxxxzero commented Jun 6, 2024

@sebastienbeau can you check the changes?

@paradoxxxzero
Copy link
Copy Markdown
Contributor Author

paradoxxxzero commented Oct 15, 2024

@sebastienbeau can you check the changes, pretty please?

sebastienbeau
sebastienbeau approved these changes Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sebastienbeau sebastienbeau mentioned this pull request Dec 5, 2024
Closed
1 task
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Apr 6, 2025
@github-actions github-actions Bot closed this May 11, 2025
@lmignon lmignon reopened this May 13, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.86%. Comparing base (bc98917) to head (a2976fc).
⚠️ Report is 8 commits behind head on 16.0.

Additional details and impacted files 
@@            Coverage Diff             @@
##             16.0    #1508      +/-   ##
==========================================
+ Coverage   94.78%   94.86%   +0.07%     
==========================================
  Files         504      506       +2     
  Lines       10478    10628     +150     
  Branches      542      546       +4     
==========================================
+ Hits         9932    10082     +150     
  Misses        394      394              
  Partials      152      152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lmignon
lmignon reviewed May 13, 2025
View reviewed changes
Comment thread shopinvader_api_sale/routers/sale_lines.py Outdated
lmignon
lmignon requested changes May 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proposal @paradoxxxzero What do you think about my proposal for the routes?

@lmignon lmignon removed the stale label May 14, 2025
@paradoxxxzero
Copy link
Copy Markdown
Contributor Author

paradoxxxzero commented Jun 2, 2025

Yes I agree it’s more logic like this.

@paradoxxxzero paradoxxxzero force-pushed the 16.0-imp-shopinvader_api_sale-add-sale_line branch from e21f162 to a2976fc Compare June 2, 2025 11:16
@paradoxxxzero
Copy link
Copy Markdown
Contributor Author

paradoxxxzero commented Jun 2, 2025

Fixed and increased coverage.

sebastienbeau
sebastienbeau approved these changes Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review) thanks for the changes)

@sebastienbeau
Copy link
Copy Markdown
Contributor

sebastienbeau commented Aug 31, 2025

@lmignon It's ok for you now ?

@lmignon
Copy link
Copy Markdown
Collaborator

lmignon commented Sep 1, 2025

/ocabot merge minor

@lmignon
Copy link
Copy Markdown
Collaborator

lmignon commented Sep 1, 2025

/ocabot merge minor

@shopinvader-git-bot
Copy link
Copy Markdown

shopinvader-git-bot commented Sep 1, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1508-by-lmignon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Sep 1, 2025
Merge PR #1508 into 16.0
a33da96 
Signed-off-by lmignon
@shopinvader-git-bot
Copy link
Copy Markdown

shopinvader-git-bot commented Sep 1, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@shopinvader-git-bot
Copy link
Copy Markdown

shopinvader-git-bot commented Sep 1, 2025

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1508-by-lmignon-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit b9706df into shopinvader:16.0 Sep 1, 2025
5 checks passed
@shopinvader-git-bot
Copy link
Copy Markdown

shopinvader-git-bot commented Sep 1, 2025

Congratulations, your PR was merged at bd0ed61. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes

@sebastienbeau sebastienbeau sebastienbeau approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 no stale ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@paradoxxxzero @sebastienbeau @lmignon @shopinvader-git-bot