Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option parameters on transaction #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option parameters on transaction #8

wants to merge 2 commits into from

Conversation

thibaultrey
Copy link
Contributor

Add an option attribute to cart transactions in order to send cart line's additional information to Odoo.

@thibaultrey thibaultrey requested a review from sbidoul November 3, 2023 16:20
sbidoul
sbidoul reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

Perhaps you could type options as object or better Map<str, number|str> to make sure a dictionary is always sent to the backend?

It would also be nice to add a little test. The test suite is already there.

@thibaultrey thibaultrey force-pushed the options branch 3 times, most recently from 9b1aa0e to 0d7f10f Compare February 5, 2024 15:35
@sbidoul
Copy link
Member

sbidoul commented Feb 12, 2024

@thibaultrey I just merged #11 that solves the same problem as your last commit, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultrey @sbidoul