Add MsgPack Marshal and Unmarshal function（Add Test Case And Change return value to unnamed） #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mote: Marshal max digits is 30. it decimal.IntPart large than 30,it will be lose extra digits.
mwoss
requested changes
Nov 23, 2021
decimal_msgpack.go
Outdated
| } | ||
|
|
||
| // UnmarshalMsg implements msgp.Unmarshaler | ||
| func (d *Decimal) UnmarshalMsg(b []byte) (o []byte, err error) { |
There was a problem hiding this comment.
Could you stick to one type of return value (names/unnamed)? Across the entire library, we use an unnamed one, so I personally opt for this approach.
There was a problem hiding this comment.
already Change MsgPack MarshalMsg and UnmarshalMsg function's return value to unnamed.
piyongcai
changed the title
Test Case was added. |
|
Thanks for providing test cases @piyongcai :) I will try to review your code later this week or next to one, as I need to get familiarized with MsgPack before doing a proper review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Marshal max digits is 31. it decimal.IntPart large than 31,it will be lose extra digits.