Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of natural logarithm #339

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Add implementation of natural logarithm #339

merged 5 commits into from
Dec 29, 2023

Conversation

mwoss
Copy link
Member

@mwoss mwoss commented Dec 28, 2023

This MR adds a natural logarithm function - one missing piece to implement properly working Power implementation.
MR also adds a constApproximation struct that represents mathematical constants like ln10 with their approximations.

Implementation was heavily inspired by CockroachDB's apd implementation of the natural logarithm. Many thanks to all the great engineers who worked on that library!

@mwoss
Copy link
Member Author

mwoss commented Dec 28, 2023

GitHub Actions is failing due to this bug - actions/setup-go#169. I need to update libraries used by pipeline and it should resolve the issue.

@mwoss mwoss merged commit 12e9241 into master Dec 29, 2023
0 of 5 checks passed
@mwoss mwoss deleted the nat-log branch December 29, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant