Add improved implementation of power operation #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust Pow implementation * Add PowWithPrecision method * Add PowInt32 method * Add PowBigInt method
epelc
pushed a commit
to greatcloak/decimal
that referenced
this pull request
Apr 7, 2024
* Adjust Pow implementation * Add PowWithPrecision method * Add PowInt32 method * Add PowBigInt method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds an improved implementation of the
Powmethod. It also adds three new methods -PowWithPrecision,PowInt32, andPowBigInt.PowWithPrecisioncan be used for calculating powers with high, specific precision.PowInt32andPowBigIntcan be used for more performant calculation of decimal powers in case the exponent is simply an integer.It took me some time to implement them as it was quite a difficult task, especially when we care about correctness and high precision. I also had to implement natural exponent and natural logarithm implementation for that.