feat(shorebird_cli): add flutter build failure recommendations#3022
Merged
feat(shorebird_cli): add flutter build failure recommendations#3022
flutter build failure recommendations#3022Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
eseidel
approved these changes
Mar 27, 2025
Contributor
eseidel
left a comment
eseidel
left a comment
There was a problem hiding this comment.
I think you will want to include flutter build ipa, flutter build aab, etc. Otherwise folks might run flutter build ios and be confused why that succeeds and shorebird release ios fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
flutter buildfailure recommendationsType of Change