-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-29997 Removing Python 2 code #345
Closed
eduardoChaucaGallegos
wants to merge
7
commits into
master
from
ticket/SG-29997-code-removing-python2
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a1243d0
six package is not used anymore, still testing
eduardoChaucaGallegos 21a0ab1
vscode filde deleted
eduardoChaucaGallegos 2e32ef0
using htlib for python3 and fixing references for new sgutils.py
eduardoChaucaGallegos 8e0b7c4
updating setup and HISTORY file
eduardoChaucaGallegos 5f7dd2e
deleting more code related to python2
eduardoChaucaGallegos e28c56f
tests fixed
eduardoChaucaGallegos 717af51
print deleted and also a test file
eduardoChaucaGallegos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,16 +18,12 @@ | |
f = open('LICENSE') | ||
license = f.read().strip() | ||
|
||
# For python 2.4 support | ||
script_args = sys.argv[1:] | ||
if (sys.version_info[0] <= 2) or (sys.version_info[0] == 2 and sys.version_info[1] <= 5): | ||
if 'install' in script_args and '--no-compile' not in script_args: | ||
script_args.append('--no-compile') | ||
|
||
|
||
setup( | ||
name='shotgun_api3', | ||
version='3.6.0', | ||
version='3.7.0', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, not in this PR |
||
description='Flow Production Tracking Python API', | ||
long_description=readme, | ||
author='Autodesk', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ Some third-party modules are bundled with `python-api` inside lib. | |
|
||
### httplib2 | ||
|
||
`httplib2` is used to make http connections to the Flow Production Tracking server. We bundle both python2 and python3 compatible versions since httplib2 chose to maintain parallel versions of the module for python 2 and 3 compatibility. | ||
`httplib2` is used to make http connections to the Flow Production Tracking server. | ||
|
||
The version of `httplib2` bundled should be updated manually, however its version is included in the unused `shotgun_api3/lib/requirements.txt` to allow Github's automated CVE notifications to work. | ||
|
||
|
@@ -23,17 +23,11 @@ See bugs: | |
|
||
The version of `mimetypes` bundled should be updated manually if necessary, however it is unlikely this will be needed, as it is only used for Python versions 2.7.0 - 2.7.9, and newer Python versions simply use the native `mimetypes` module. | ||
|
||
### six | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see |
||
|
||
Six is a Python 2/3 compatibility library. In python-api, it's used to make simultaneous support for Python on 2 and 3 easier to maintain and more readable, but allowing the use of common helper functions, unified interfaces for modules that changed, and variables to ease type comparisons. For more on six, see the [documentation](https://six.readthedocs.io/). | ||
|
||
The version of `six` bundled should be updated manually, however its version is included in the unused `shotgun_api3/lib/requirements.txt` to allow Github's automated CVE notifications to work. | ||
|
||
## Flow Production Tracking Modules | ||
|
||
### sgsix | ||
|
||
`sgsix` is a module that contains extensions to `six`. These might be additional helper functions, variables, etc. that supplement six's functionality. It is intended that `sgsix` can be used within other packages that include or depend on the `python-api` package as well. | ||
`sgutils` is a module that contains additional helper functions, variables, etc. that supplement six's functionality. It is intended that `sgutils` can be used within other packages that include or depend on the `python-api` package as well. | ||
|
||
### sgtimezone | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only change this file when we prepare a release of python-api. Not when we work on the code.