Tk framework adobe Code Review

[martinminsel]

First pass review for the general structure
This is not ment to be merged yet

[martinminsel]

I updated this pull request with the latest code. Ready for a detailed code review.
Please Note:

In order to make it work you need to get the tk-framework-adobe branches of the following projects:
tk-multi-launchapp
tk-config-default2/tk-config-basic
tk-aftereffectscc
tk-photoshopcc
tk-framework-adobe

Be aware, that you have to configure the app-locations in the configs accordingly.

[thebeeland]

Whew...that's a big framework!

In general I think it's looking really good. A lot of the comments I have are pretty minor in scope, so hopefully a second pass at it won't take too much effort. I would like to take another look at it once you've gone through all of my comments.

Thanks so much for all of the hard work!

[martinminsel]

Hi @thebeeland ,
I did the changes for this. Thanks for your detailed review.
Let me know your thoughts.
Cheers.

[thebeeland]

The changes you made look good. The only remaining comments I have are around the README, so if you can tackle those few things I think we're in pretty good shape here.

I'll take one last look at the README once you've made a pass at that.

[thebeeland]

One more note now that I've caught up with Manne and Rob. It sounds like Sphinx docs are also on the table as something that's needed to be done. We have examples of how to piece that together in our other frameworks (qtwidgets is a great example). I'm happy to review that work, as well, once it's ready. Just let us know!

[manneohrstrom]

Just a quick note as i am looking at this - possible that @thebeeland has already mentioned it - but we should rename the folder python/tk_adobe_basic to python/tk_framework_adobe so that we follow our naming conventions.

[manneohrstrom]

This looks good to me (apart from the missing sphinx docs). I say we merge this with master and do the sphinx docs (#2 ) as a separate PR and branch. I will ping the @thebeeland to remind him to take a look and give his ✅

[thebeeland]

I like it. Solid effort all around! 👍