Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TextInput.js #550

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

StephenTANM
Copy link

@StephenTANM StephenTANM commented Dec 4, 2020

Fix for onFocus & onBlur silently failing. Reproduction example below...

import { TextInput } from "@shoutem/ui";

interface InitialState {
  focused: Boolean;
}
const textInput = React.createRef();

const Input = (props: any) => {

const [state, setstate] = useState<InitialState>({
    focused: false,
  });

  const onFocus = () => {
    setstate((oldstate) => ({
      ...state,
      focused: true,
    }));
  };

  const onBlur = () => {
    setstate((oldstate) => ({
      ...state,
      focused: false,
    }));
  };

  return (
    <TextInput
      onFocus={onFocus}
      onBlur={onBlur}
      autoFocus
    />
}

Fix for onFocus & onBlur silently failing when using handling both methods
Copy link
Collaborator

@Definitely-Not-Vlad Definitely-Not-Vlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thinking, somehow it didn't occur to me that people would want to include their own specific onFocus and onBlur. Just an oversight.

@@ -22,12 +22,13 @@ class TextInput extends PureComponent {

handleBlur() {
this.setState({ isFocused: false });
this.props.onBlur()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure onBlur from this.props on the first line of the method with a fallback to null if it isn't set. This should be followed by a newline. Then check if onBlur is truthy and run it:

handleBlur() {
  const { onBlur = null } = this.props;

  this.setState({ isFocused: false });
  if (onBlur) {
    onBlur();
  }
}

}

handleFocus() {
this.setState({ isFocused: true });
this.props.onFocus()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure onFocus from this.props on the first line of the method with a fallback to null if it isn't set. This should be followed by a newline. Then check if onFocus is truthy and run it:

handleFocus() {
  const { onFocus = null } = this.props;

  this.setState({ isFocused: true });
  if (onFocus) {
    onFocus();
  }
}

Comment on lines 31 to 32
}

render() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduce this newline between handleFocus and render, we separate all methods with a newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants