-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @actions/artifact to v2 #17
base: main
Are you sure you want to change the base?
Conversation
@mkenworthy actually sorry this branch comes from my fork, so you should change the whole line to use my fork from
to
|
which build files do I need to change this in? I already tried it and it complained about the 'wrong Python version' bug from a few weeks ago... |
e51ea54
to
6185ce4
Compare
and
This was my fault, apologies! |
OK I am testing this here, but it seems that their API has been changed, so I'll have to look into it... |
0de6a24
to
962d5ed
Compare
OK I think I managed to fix this. You can check here that in my test project I used first the action from the main branch failing to complete the workflow, while it succeeded when using this branch. @mkenworthy can you also test it with your project as we discussed above? @dfm would you like to crosscheck I did things correctly? |
Just tried this on my project, and it works! Thank you, it's great to have the compiled PDF. |
Great! @mkenworthy I will wait a few days to see if some other project maintainer wants to add something When this PR will be merged you should be notified automatically, then remember to change your action specification to the |
This is needed because of the recurrent upstream issue of the dependent action upload-artifact (see actions/upload-artifact#490) which is currently causing showyourwork/showyourwork#526.
@mkenworthy could you test this PR by using this version of the action from your project's workflows?
Same as last time: change the name of the branch, now from
main
toupdate-artifact-action
@dfm the node modules bundle is now 120Mb, so ~6 times heavier than before; I think this is already only the production dependencies (I used
npm install --omit=dev
) and the heaviest dep is typescript which in my understanding is what the new version of the action in subject is using, so I do not know if we can make it smaller now.Closes #16
Closes showyourwork/showyourwork#526