fix: allow extension passkey provider on NodeWarden domain#163
Closed
fix: allow extension passkey provider on NodeWarden domain#163
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
nodewarden | 0f4873a | Mar 31 2026, 03:18 PM |
There was a problem hiding this comment.
Pull request overview
This PR adjusts OAuth/token responses so Bitwarden browser extensions treat NodeWarden as an “official” server for passkey-provider selection, enabling the extension’s in-browser passkey UI instead of falling back to the OS/system UI.
Changes:
- Set
unofficialServertofalsein password and refresh token responses. - Set
unofficialServertofalsein send-access token responses. - Set
unofficialServertofalsein passkey-login token responses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/handlers/identity.ts |
Updates multiple token response payloads to return unofficialServer: false. |
src/handlers/passkeys.ts |
Updates passkey-login finish response token payload to return unofficialServer: false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unofficialServer: falseFiles
src/handlers/identity.tssrc/handlers/passkeys.tsWhy
When the extension account is connected to NodeWarden, passkey flows on the NodeWarden site were falling back to the OS/system passkey UI instead of invoking the Bitwarden extension passkey UI. This patch removes the self-hosted/unofficial flag from token responses so extension behavior matches official-server expectations for in-browser passkey provider prompting.
Codex Task