Skip to content

fix: allow extension passkey provider on NodeWarden domain#163

Closed
shuaiplus wants to merge 1 commit intomainfrom
codex/fix-passkey-authentication-issue-in-nodewarden-y4xhus
Closed

fix: allow extension passkey provider on NodeWarden domain#163
shuaiplus wants to merge 1 commit intomainfrom
codex/fix-passkey-authentication-issue-in-nodewarden-y4xhus

Conversation

@shuaiplus
Copy link
Copy Markdown
Owner

Summary

  • changed OAuth/token payloads to return unofficialServer: false
  • updated both password/refresh/send token responses and passkey-login token response
  • aligns NodeWarden responses with official-server behavior expected by Bitwarden browser extensions when deciding passkey provider behavior

Files

  • src/handlers/identity.ts
  • src/handlers/passkeys.ts

Why

When the extension account is connected to NodeWarden, passkey flows on the NodeWarden site were falling back to the OS/system passkey UI instead of invoking the Bitwarden extension passkey UI. This patch removes the self-hosted/unofficial flag from token responses so extension behavior matches official-server expectations for in-browser passkey provider prompting.


Codex Task

Copilot AI review requested due to automatic review settings March 31, 2026 15:17
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 31, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
nodewarden 0f4873a Mar 31 2026, 03:18 PM

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts OAuth/token responses so Bitwarden browser extensions treat NodeWarden as an “official” server for passkey-provider selection, enabling the extension’s in-browser passkey UI instead of falling back to the OS/system UI.

Changes:

  • Set unofficialServer to false in password and refresh token responses.
  • Set unofficialServer to false in send-access token responses.
  • Set unofficialServer to false in passkey-login token responses.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/handlers/identity.ts Updates multiple token response payloads to return unofficialServer: false.
src/handlers/passkeys.ts Updates passkey-login finish response token payload to return unofficialServer: false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shuaiplus shuaiplus closed this Apr 7, 2026
@shuaiplus shuaiplus deleted the codex/fix-passkey-authentication-issue-in-nodewarden-y4xhus branch April 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants