fix: test cases updated

shubhadip · Sep 11, 2022 · c94197d · c94197d
1 parent 7597c58
commit c94197d
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 9 deletions.
diff --git a/coverage/clover.xml b/coverage/clover.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<coverage generated="1662867335730" clover="3.2.0">
-  <project timestamp="1662867335730" name="All files">
+<coverage generated="1662908149967" clover="3.2.0">
+  <project timestamp="1662908149967" name="All files">
     <metrics statements="51" coveredstatements="51" conditionals="47" coveredconditionals="42" methods="1" coveredmethods="1" elements="99" coveredelements="94" complexity="0" loc="51" ncloc="51" packages="1" files="1" classes="1"/>
     <file name="Index.svelte" path="/Users/shubhadipmaity/projects/svelte-journey/svelte-otp/src/lib/Index.svelte">
       <metrics statements="51" coveredstatements="51" conditionals="47" coveredconditionals="42" methods="1" coveredmethods="1"/>

diff --git a/coverage/lcov-report/Index.svelte.html b/coverage/lcov-report/Index.svelte.html
@@ -511,7 +511,7 @@ <h1><a href="index.html">All files</a> Index.svelte</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2022-09-11T03:35:35.726Z
+                at 2022-09-11T14:55:49.961Z
             </div>
         <script src="prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/index.html b/coverage/lcov-report/index.html
@@ -101,7 +101,7 @@ <h1>All files</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2022-09-11T03:35:35.726Z
+                at 2022-09-11T14:55:49.961Z
             </div>
         <script src="prettify.js"></script>
         <script>

diff --git a/src/__test__/otp.spec.js b/src/__test__/otp.spec.js
@@ -50,9 +50,20 @@ test("Case 3: Otp Component Renders masked Inputs", () => {
 		maskInput: true,
 	});
 
-	screen.getAllByRole('input').forEach((o) => {
-		expect(o).toHaveAttribute('type', 'password');	
-	});
+	/**
+	 * need to find a better way
+	 * getByRole doesn't work since type is password
+	 */
+
+	const input = screen.getByTestId('elem-0')
+	const input2 = screen.getByTestId('elem-1')
+	const input3 = screen.getByTestId('elem-2')
+	const input4 = screen.getByTestId('elem-3')
+
+	expect(input).toHaveAttribute("type","password")
+	expect(input2).toHaveAttribute("type","password")
+	expect(input3).toHaveAttribute("type","password")
+	expect(input4).toHaveAttribute("type","password")
 
 });
 
@@ -63,7 +74,7 @@ test("Case 4: Otp Component Renders With Initial Value", () => {
 	/**
 	 * need to find a better way
 	 */
-	screen.getAllByRole('input').forEach((o, index) => {
+	screen.getAllByRole('textbox').forEach((o, index) => {
 		const shouldHaveValue = prefillValue[index]
 		expect(o).toHaveValue(shouldHaveValue)
 	})

diff --git a/src/lib/TextInput/Index.svelte b/src/lib/TextInput/Index.svelte
@@ -24,7 +24,7 @@
 
 <div class={`${customInputWrapperClass} textcontainer`}>
   <input
-    role="input"
+    name="input"
 		type={inputType}
 		{placeholder}
 		{value}