-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify fee collection logic and update dependencies #23
Conversation
Removed unnecessary vector allocation in the fee collection logic to streamline method parameters. Updated the `uniswap-v3-sdk` dependency to version 3.1.1 for improved compatibility. Also fixed a minor formatting issue in the `has_permission` utility function.
WalkthroughThe pull request encompasses minor updates to the Uniswap V4 SDK, including a package version bump to 0.1.1, a dependency upgrade for uniswap-v3-sdk, and some internal code refinements. The changes primarily involve streamlining the Changes
Poem
[Adjusts glasses with scientific precision] Fascinating! The code has undergone a most logical transformation. Bazinga! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🔇 Additional comments (4)src/position_manager.rs (1)
This direct return from Cargo.toml (2)
Upgrading from
Raising src/utils/hook.rs (1)
The parentheses highlight the shift operation. No functional changes, but a tidy improvement nonetheless. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Removed unnecessary vector allocation in the fee collection logic to streamline method parameters. Updated the
uniswap-v3-sdk
dependency to version 3.1.1 for improved compatibility. Also fixed a minor formatting issue in thehas_permission
utility function.Summary by CodeRabbit
Chores
0.1.0
to0.1.1
uniswap-v3-sdk
dependency from version3.0.0
to3.1.1
Refactor
collect_call_parameters
function inposition_manager.rs
has_permission
function inhook.rs