fix: remove unused sqrtPriceLimitX96 field from swap structs

[shuhuiluo]

The sqrtPriceLimitX96 field has been removed from swap-related structs and associated test cases. This cleanup eliminates redundant dependencies and simplifies the struct definitions.

Summary by CodeRabbit

• Code Refactoring

  • Removed sqrtPriceLimitX96 parameter from swap-related structures and actions
  • Simplified import statements in utility files

• Impact

  • Changes may affect how price limits are handled during swap operations
  • Potential simplification of swap parameter handling

[coderabbitai]

Walkthrough

The pull request removes the sqrtPriceLimitX96 parameter from swap-related structures and actions across multiple files. This modification simplifies the parameter set for swap operations in the codebase, specifically targeting SwapExactInSingleParams and SwapExactOutSingleParams structs, and corresponding action definitions. The changes are consistent across src/abi.rs, src/utils/v4_base_actions_parser.rs, and src/utils/v4_planner.rs.

Changes

File	Change Summary
src/abi.rs	Removed sqrtPriceLimitX96 from SwapExactInSingleParams and SwapExactOutSingleParams structs
src/utils/v4_base_actions_parser.rs	Deleted sqrtPriceLimitX96 parameter from Actions::SWAP_EXACT_IN_SINGLE and Actions::SWAP_EXACT_OUT_SINGLE
src/utils/v4_planner.rs	Removed sqrtPriceLimitX96 variable in test case, updated import statement

Possibly related PRs

• chore: refactor ABI structs and consolidate modules #2: Defines the SwapExactInSingleParams and SwapExactOutSingleParams structs
• feat: add v4_base_actions_parser module #3: Modifies swap action parameter definitions
• test: add unit tests for parsing calldata in v4 action parser #16: Includes unit tests for parse_calldata function
• fix: remove SETTLE_TAKE_PAIR and update action discriminants #20: Updates Actions enum with swap-related actions

Suggested reviewers

• malik672

Poem

Swap parameters trimmed with care,
sqrtPriceLimitX96 no longer there!
Code simplified, streamlined and bright,
Rust's elegance shining just right! 🧩
Refactoring dance, a developer's delight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f193180 and 657125a.

📒 Files selected for processing (3)

• src/abi.rs (0 hunks)
• src/utils/v4_base_actions_parser.rs (1 hunks)
• src/utils/v4_planner.rs (2 hunks)

💤 Files with no reviewable changes (1)

• src/abi.rs

🔇 Additional comments (3)

src/utils/v4_base_actions_parser.rs (2)

27-27: LGTM! Import cleanup aligns with struct changes.

The removal of the U160 import is consistent with the removal of the sqrtPriceLimitX96 field.

---

Line range hint 342-342: LGTM! Test data updated correctly.

The hex data has been properly adjusted to reflect the removal of the sqrtPriceLimitX96 field while maintaining test functionality.

src/utils/v4_planner.rs (1)

232-232: LGTM! Import statement properly updated.

As someone with multiple doctorates worth of knowledge in my head, I can confidently state that the removal of the U160 import is logically consistent with the elimination of the sqrtPriceLimitX96 field.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.