Shutter service #560
Open
Shutter service #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test/registry event
Test/newblock dec trigger
blockchainluffy
force-pushed
the
shutter-service
branch
2 times, most recently
from
9225ac9 to
d86f29f
Compare
blockchainluffy
force-pushed
the
shutter-service
branch
from
d86f29f to
85e4578
Compare
blockchainluffy
force-pushed
the
shutter-service
branch
from
930cb54 to
f6dc1a2
Compare
blockchainluffy
force-pushed
the
shutter-service
branch
from
8e41380 to
12c2328
Compare
ulope
approved these changes
Jan 10, 2025
| block_number bigint NOT NULL CHECK (block_number >= 0) | ||
| ); | ||
|
|
||
| CREATE TABLE current_decryption_trigger( |
There was a problem hiding this comment.
I don't quite understand why it's "current" decryption trigger?
They don't seem to get deleted, wouldn't just decryption_trigger make more sense?
| @@ -0,0 +1,53 @@ | |||
| package shutterservice | |||
There was a problem hiding this comment.
The other keyper implementations all have keyper in their command name. I think we should keep that convention.
| "github.com/shutter-network/rolling-shutter/rolling-shutter/medley/metricsserver" | ||
| "github.com/shutter-network/rolling-shutter/rolling-shutter/p2p" | ||
| ) | ||
|
|
There was a problem hiding this comment.
This is missing an assignment check to verify the structs actually satisfy the interface. See for example:
rolling-shutter/rolling-shutter/keyperimpl/gnosis/config.go
Lines 21 to 25 in bae90ac
| var Definition db.Definition | ||
|
|
||
| func init() { | ||
| def, err := db.NewSQLCDefinition(files, "sql/", "shutterserviceKeyper", 1) |
There was a problem hiding this comment.
Nitpick: In the gnosis impl keyper is lower case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.