Add Mish class inheriting from Lamda layer #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelMeudec
approved these changes
Jun 12, 2020
AntoineToubhans
requested changes
Jun 17, 2020
tf2_yolov4/layers.py
Outdated
|
|
||
| return x | ||
|
|
||
|
|
||
| class Mish(Lambda): |
There was a problem hiding this comment.
@lmontier je comprends pas à quoi sert cette classe: c'est la même chose que Lambda(function=tfa.activations.mish) et elle ne sert qu'une seule fois.
There was a problem hiding this comment.
@AntoineToubhans je crois que c'est pour qu'elle apparaisse de manière plus friendly dans le plot_model de Keras, mais je suis pas hyper chaud pour merger non plus
There was a problem hiding this comment.
@AntoineToubhans @RaphaelMeudec , ça fait deux choses :
- On mélange des keras.layer et des keras.functions dans nos models, ce qui fait que notamment la function plot_model de keras crash (mais je me dis que peut être d'autres utilis peuvent péter également...). Il me semble que Clément nous avais également indiqué ce genre de retour. D'où le Lambda(function=tfa.activations.mish) ou le Mish()
- Utiliser Lambda(function=tfa.activations.mish) fait que quand tu examines ton modèle (ou que tu le plot), le nom de tes layers s'appellent "Lambda_x" , alors que si tu redéfinis une classe "Mish", ils s'appelleront "Mish_x"... C'est assez chiant car on utilise ailleurs d'autre Lambda... J'ai essayé de faire autrement, genre forcer le name=... mais pour ça il faut avoir accès à ton index du layer et je n'ai pas réussi. Si vous savez comment faire ça par contre je suis chaud!
|
Closing this PR as it will be integrated with #60 along with the TFLite converter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.