Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import nuxt composables from #imports #562

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

danielroe
Copy link
Contributor

This is a DX improvement when developing - we can avoid loading the entire barrel file at #app by using the new granular imports merged in nuxt/nuxt#23951.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser
Copy link
Member

Hi @danielroe 👋

Thanks for your PR. I will pass this onto @BracketJohn for a review!

@zoey-kaiser
Copy link
Member

Quick update on this: Before merging this PR, we will need to upgrade our Nuxt version from 3.4.2 to at least 3.8.1, in which this feature was released.

Once I merge the Nuxt upgrade, I will then move forward with merging this PR too! 🤗

Copy link
Contributor Author

This PR should be backwards-compatible. It will only result in a perf benefit from 3.8.1 onwards though.

@zoey-kaiser
Copy link
Member

zoey-kaiser commented Nov 20, 2023

This PR should be backwards-compatible. It will only result in a perf benefit from 3.8.1 onwards though.

That is very cool! Ill pull this branch then and test it! Thanks for all of your input @danielroe ❤️

// Edit, could you please also have a look at the merge conflicts? We recently slightly rearranged our docs.

@danielroe
Copy link
Contributor Author

done ✅

@zoey-kaiser zoey-kaiser merged commit 38ce7c5 into sidebase:main Nov 23, 2023
3 checks passed
@danielroe danielroe deleted the app-import branch November 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants