-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import nuxt composables from #imports #562
Conversation
Hi @danielroe 👋 Thanks for your PR. I will pass this onto @BracketJohn for a review! |
Quick update on this: Before merging this PR, we will need to upgrade our Nuxt version from Once I merge the Nuxt upgrade, I will then move forward with merging this PR too! 🤗 |
This PR should be backwards-compatible. It will only result in a perf benefit from 3.8.1 onwards though. |
That is very cool! Ill pull this branch then and test it! Thanks for all of your input @danielroe ❤️ // Edit, could you please also have a look at the merge conflicts? We recently slightly rearranged our docs. |
88d2bb8
to
4e721af
Compare
done ✅ |
This is a DX improvement when developing - we can avoid loading the entire barrel file at
#app
by using the new granular imports merged in nuxt/nuxt#23951.Checklist:
#
)