Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#990): use a dedicated host calculation for authjs #992

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phoenix-ru
Copy link
Collaborator

πŸ”— Linked issue

Closes #990

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

After #984, one of well-hidden bugs was uncovered. authjs does a lot of implicit and unintuitive URL manipulation under the hood, leading to only /api/auth path working correctly out-of-the-box.
This PR reworks nuxtAuthHandler passing parameters to authjs to account for the inconsistency. Instead of passing full request URL or just its origin, we now pass baseURL to authjs handler.
This leads to no implicit /api/auth being added and also callback paths being built correctly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Jan 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@992

commit: e05f7fc

@phoenix-ru phoenix-ru marked this pull request as draft January 24, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid path used for auth-endpoint
1 participant