Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stargz-snapshotter #229

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

andrewrynhard
Copy link
Member

Adds the Stargz Snapshotter service

@andrewrynhard andrewrynhard force-pushed the stargz-snapshotter branch 4 times, most recently from 899b831 to 2116844 Compare September 13, 2023 21:30
container-runtime/vars.yaml Outdated Show resolved Hide resolved
@andrewrynhard andrewrynhard force-pushed the stargz-snapshotter branch 3 times, most recently from b3dbe16 to baeaf1c Compare September 14, 2023 16:59
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also fyi, it has serious bugs which are not fixed: containerd/stargz-snapshotter#215

@smira
Copy link
Member

smira commented Sep 14, 2023

and also dragonflyoss/nydus#50 (comment)

Adds the Stargz Snapshotter service

Signed-off-by: Andrew Rynhard <[email protected]>
@andrewrynhard
Copy link
Member Author

/m

@talos-bot talos-bot merged commit 1c94a09 into siderolabs:main Sep 14, 2023
@andrewrynhard andrewrynhard deleted the stargz-snapshotter branch September 14, 2023 23:25
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. this was merged without updating top-level README.md. I think I had review comment about it

@andrewrynhard
Copy link
Member Author

hm. this was merged without updating top-level README.md. I think I had review comment about it

I don't see a comment with that but I can submit a PR to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants